Add back the deleted public methods as deprecated #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minbi
reviewed
Apr 30, 2019
| @@ -37,6 +37,24 @@ | |||
| private final CacheHeaders cacheHeaders; | |||
| private final CacheKeyBuilder cacheKeyBuilder; | |||
|
|
|||
| /** | |||
| * @deprecated Since 2.8.1. This method will be removed in the next minor version. | |||
| * Please use the other constructor instead. | |||
There was a problem hiding this comment.
Please use javadoc link notation.
| @@ -250,6 +250,20 @@ public boolean optional() { | |||
| return conditions; | |||
| } | |||
|
|
|||
| /** | |||
| * @deprecated Since 2.8.1. This method will be removed in the next minor version. | |||
| * Please use CacheKeyBuilder instead. | |||
There was a problem hiding this comment.
Please use javadoc link notation.
minbi
approved these changes
Apr 30, 2019
desokroshan
force-pushed
the
desokroshan/deprecate-methods
branch
from
a5187a0 to
a776163
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.